WebProfiler debugging integration #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,3 +3,5 @@ type: module | |||
| description: 'React on events and conditionally evaluate actions.' | |||
| package: Rules | |||
| core: 8.x | |||
| test_dependency: | |||
There was a problem hiding this comment.
Sorry, this one is called test_dependencies :)
| /** | ||
| * Defines a service profiler for the web profiler module. | ||
| */ | ||
| class WebProfilerServiceProvider extends ServiceProviderBase { |
There was a problem hiding this comment.
This has to be called RulesServiceProvider and must be placed into the Drupal\rules namespace to let Drupal find it
|
Please call the namespace WebProfiler (camel case) as well and also the files themselves! |
| public function getErrorLogsCount() { | ||
| $amount = 0; | ||
| array_walk($this->data['logs'], function ($log) use (&$amount) { | ||
| if (in_array($log['level'], array('error', 'critical', 'alert', 'emergency'))) { |
| /** | ||
| * Tests that the webprofile shows rules debug log and respects rules settings. | ||
| * | ||
| * @group block |
added 2 commits
April 17, 2015 19:25
M1r1k
changed the title
|
Merged back head into the webprofiler branch here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it depends on #170